search

neuroinformatics-unit / python-cookiecutter

Utility to create a basic Python project structure with tests, CI etc.
BSD 3-Clause "New" or "Revised" License
24 stars 3 forks source link

Adding whitespace/newline trimmers and `isort` #8

Closed samcunliffe closed 2 years ago

samcunliffe commented 2 years ago

I noticed isort was missing (you mentioned it in the dev guidelines with us. Perhaps/probably you're already on this.

Also, I propose adding trailing-whitespace and end-of-file-fixer from the list of pre-cooked pre-commit pre-commit hooks. Which do what you'd imagine.

To quote a wise man:

"It's like having the worlds pickiest python developer watching over your shoulder."

adamltyson commented 2 years ago

Hey @samcunliffe, sorry the PR to update pre-commit hasn't been merged yet. The current state of the config is here: https://github.com/SainsburyWellcomeCentre/python-cookiecutter/blob/9aa11ac4729aca7287ea9aa0b0f0dfd065546d85/%7B%7Bcookiecutter.package_name%7D%7D/.pre-commit-config.yaml#L1-L33

samcunliffe commented 2 years ago

Oh great! You're already doing them both.

samcunliffe commented 2 years ago

[ Sorry for the noise. Shoulda checked #6. ]