neuroinformatics-unit / python-cookiecutter

Utility to create a basic Python project structure with tests, CI etc.

BSD 3-Clause "New" or "Revised" License

22 stars 3 forks source link

drop 3.8, add 3.11 in template pyproject #89

Closed alessandrofelder closed 11 months ago

alessandrofelder commented 11 months ago

Description

What is this PR

[x] Bug fix
[ ] Addition of a new feature
[ ] Other

Why is this PR needed?

88 only moved to NEP 29 for this repo, and was missing updates to template itself.

What does this PR do?

References

Closes #38

How has this PR been tested?

Luckily, we already had a good test, so

when I updated the template pyproject but not the test, the CI failed as expected

E       AssertionError: assert '>=3.9.0' == '>=3.8.0'
E         - >=3.8.0
E         ?     ^
E         + >=3.9.0
E         ?     ^

when I also updated the test in line with NEP 3.9, the CI passed again

Is this a breaking change?

NA

Does this PR require an update to the documentation?

No

Checklist:

[NA] The code has been tested locally
[x] Tests have been added to cover all new functionality
[NA] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

alessandrofelder commented 11 months ago

Good catch - I'll remove cibuildwheel now, but in a separate PR.