search

neurolibre / neurolibre.com

Website for NeuroLibre.
https://www.neurolibre.com/
MIT License
5 stars 2 forks source link

Fix links to Twitter & GitHub #15

Closed alexandreroutier closed 4 years ago

alexandreroutier commented 4 years ago

Hello,

I discovered Neurolibre.com thanks to the Open Science Room of OHBM, this is a great work! :)

I noticed that links to Twitter & GitHub accounts were linked to cboettig (the designer of the theme you use).

I modified the config file hoping that it will fix this. BTW, the only mention remains:

$ git grep -n "cboettig"
.gitmodules:3:  url = https://github.com/cboettig/hugo-now-ui.git

which I think should not be touched.

Best, Alexandre

pbellec commented 4 years ago

Thanks a lot for the contribution! It's awesome to get help even before we launch :) I have requested a review by @agahkarakuzu because this may be already be part of other work he is doing and has not yet been merged.

agahkarakuzu commented 4 years ago

Thanks @alexandreroutier, this PR resolves #14 :) We should indeed keep the submodule link as is.

@pbellec I did change them, but it is great to have people contributing, merging this PR 🥇

alexandreroutier commented 4 years ago

Thanks a lot for the contribution! It's awesome to get help even before we launch :) I have requested a review by @agahkarakuzu because this may be already be part of other work he is doing and has not yet been merged.

Sure, no problem! :)

Since I wanted to follow the development on this nice project, I noticed this small issue with the social accounts.

Best, Alex