search

neurolibre / submit

Submission guideline for neurolibre
MIT License
8 stars 3 forks source link

Tool for notebook review #17

Open ltetrel opened 5 years ago

ltetrel commented 5 years ago

For now we ask the reviewers to review the notebook manually, but we could use a tool like reviewnb.

Questions remain on how we can integrate smoothly in the review process ?

pbellec commented 5 years ago

I've already enabled the integration on the boutiques-tutorial repo. A bot automatically posts a link to notebook diffs as part of a PR. See the example here https://github.com/neurolibre/boutiques-tutorial/pull/12

what do you think?

mathieuboudreau commented 5 years ago

That works great! Looks useful to me

ltetrel commented 5 years ago

Nice @pbellec ! Can you explain the process more deeply ? Who is making the PR (the author I think) and how the reviewer interact with it ?