search

neuromatch / climate-course-content

Computational Climate Science syllabus
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

Updated W1D5 tutorials #21

Closed brian-rose closed 3 months ago

brian-rose commented 4 months ago

This PR introduces the 2024 updates to the notebooks for W1D5: Introduction to Climate Modeling.

iamzoltan commented 3 months ago

hey @brian-rose, I will create a W1D5 update branch for you to make your PR.

brian-rose commented 3 months ago

Looks great! I changed your base branch to the W1D5-updates one I created. A few notes/task to make sure the pipeline builds smoothly:

  • [x] Use the same python version as our build pipeline does (in this case, it is 3.9)
  • [x] Change the number of tutorials in the materials.yml file for W1D5 from 7 to 8 (the new tutorial won't build otherwise)
  • [x] Add some content for W2D1_Tutorial1 as the build expects it (its ok if this is just placeholder for now, as long as the format for the header cells match the rest of the tutorials)

Would you also add my name to the production editors list for the Tutorials?

Let me know if I can help.

Hi @iamzoltan, thanks for helping to get the build going here.

I implemented the three changes you asked for. I created a local python 3.9 environment and verified that all the notebooks run properly, then removed all output again before checking them in here.

I apologize for this, but I'm afraid I don't know your name so I haven't yet added it to the list of production editors.

iamzoltan commented 3 months ago

@brian-rose Amazing! Great. pinged you my name

brian-rose commented 3 months ago

@brian-rose Amazing! Great. pinged you my name

Added to the notebooks, thanks.