Closed toni-neurosc closed 4 months ago
Thanks @toni-neurosc for that PR. Since there were a couple of changes in the branch refactor_lsl_stream (https://github.com/neuromodulation/py_neuromodulation/tree/refactor_lsl_stream) I would not directly merge it. Maybe you can check @SamedVossberg to include those lazy import changes in your next PR
ok @timonmerk I have change this PR then to be a merge into the refactor_lsl_stream
branch, at some point I will resolve the conflicts and let @SamedVossberg merge if he's alright with that
Hi @timonmerk, I made some changes on top of the recent LSL merge. Summary:
It's in general problematic to have 2 sources of truth like in the case of GenericStream getting an sfreq value from the user and one from the stream. It's also quite annoying that Python does not support overloaded constructors like C++. Maybe when I'm done with the Settings I will also incorporate Pydantic into the stream classes to handle this better.