search

neuromodulation / py_neuromodulation

Real-time analysis of intracranial neurophysiology recordings.
https://neuromodulation.github.io/py_neuromodulation/
MIT License
42 stars 9 forks source link

Remove features dictionary as input to calc_feature #349

Closed toni-neurosc closed 3 months ago

toni-neurosc commented 3 months ago

The calculation of each feature is independent of the rest, so having "features_compute" as an input argument to calc_feature suggested otherwise and was not necessary. It might also pose problems if we decide to multi-thread the feature calculation at the DataProcessor or FeatureProcessors level.

toni-neurosc commented 3 months ago

I see, then let's wait on it until the project develops in a way that we need to go one way or the other. There might be other ways to handle the interdependency as well. Right now this can wait. Just to know, which feature is currently calculating "ratio between beta and gamma"?

timonmerk commented 3 months ago

Currently there is no feature that is doing that. But I've seen that many times that it was very relevant for decoding. For example Zixiao's paper used those: https://www.nature.com/articles/s41746-024-01115-7