neuromore / studio

neuromore Studio is your all-in-one biofeedback suite
https://neuromore.com
122 stars 39 forks source link

NaN Logic #319

Open stellarpower opened 1 week ago

stellarpower commented 1 week ago

https://github.com/neuromore/studio/blob/1.7.3/src/Engine/Core/Math.inl#L11

Not sure how this is apparently working (or if it is) but the NaN should never compare equal to itself. On earlier versions of C isnan was often a macro that expanded to this comparison. isnan is in the standard library since C++11 so IMO this ought to be used on all platforms.