neuromorph / glass_grid

A Gnome Shell extension showing an overlay glass panel to manage installed extensions.
GNU General Public License v3.0
2 stars 0 forks source link

Extension interferes with Desktop Cube #4

Closed FelixFourcolor closed 10 months ago

FelixFourcolor commented 10 months ago

Desktop Cube has a feature that allows you to click and drag the desktop or the panel to switch workspaces (i.e. to "rotate the cube"). When this extension is enabled, that feature doesn't work.

(With Desktop Cube you can also click and drag the overview to switch workspaces; that still works with this extension.)


Gnome 45

neuromorph commented 10 months ago

This should not happen as I don't see a conflict with that extension. Frankly, I hadn't used Desktop Cube, so I just installed and tried it on my laptop with Gnome <45 and then also in VM with Gnome 45 and it works in both cases. Here is a cast from the VM running Gnome 45, I hope this is what you are referring to. I first do it with panel and then with desktop but the mouse pointer was not captured in recording. Also, if the Glass Grid panel is open then while Cube still works, the Glass grid panel will not move as it is not part of any workspace, it is like the Top bar panel for e.g.

Screencast from 11-11-23 03:50:57 PM IST.webm

FelixFourcolor commented 10 months ago

I see what's going on.

(I can't capture mouse clicks on-video, but you get the point when my mouse moves back and forth.)

https://github.com/neuromorph/glass_grid/assets/34260584/5c4d181c-6519-4a1b-9694-056239fca08a

The extension only interferes with Desktop Cube when you do horizontal movements. Seems like it interprets all horizontal click-n-drags as you trying to scroll the glass panel, even if you don't click on the panel itself. Meanwhile vertical click-n-drags are untouched, so Desktop Cube still works.

When I wrote the issue I happened to only test horizontal movements, while you only tested vetical movements. So there's a miscommunication :)

neuromorph commented 10 months ago

Ah, I wasn't aware that Desktop Cube works with horizontal swipes. I tested it now and yes, I can reproduce your issue. It is still unclear and a bit weird that it happens. I glanced through Desktop Cube code and got an idea of where the issue could be and so I tried a few things and am able to isolate it to the Swipe tracker. Cube alters Gnome's swipe tracker from Overview to make it work on desktop while I create a new swipe tracker for the scrolling widget only so should not interfere but it does. Anyway, I plan to disable it when the glass panel is not open so that Cube will work. On the other hand Grid will take over when it is open which makes sense. I will update here once I have it ready and will also add the fix for the artifact issue.

FelixFourcolor commented 10 months ago

Thank you!

neuromorph commented 10 months ago

Hello Felix,

I have a release with fixes ready for test. Updates:

Release available here. You will need to follow same steps as before for local install. Let me know how it goes.

FelixFourcolor commented 10 months ago

Both fixes work. Thank you so much!