neuromorph / openbar

A GNOME Shell extension for theming Gnome Top Bar / Top Panel, Menus, Dash/Dock, Gnome Shell and Gtk/Flatpak Apps.
https://extensions.gnome.org/extension/6580/open-bar/
GNU General Public License v3.0
268 stars 4 forks source link

global menu got zero margin #13

Closed MarsSwimmer closed 9 months ago

MarsSwimmer commented 9 months ago

global menubar extension: fildem fix for gnome-45

OS: ubuntu23.10

截图 2024-02-18 15-26-14

neuromorph commented 9 months ago

Hello, I do not have this setup where I can test it. The extension doesn't seem to be available on e.g.o after Gnome 41. It seems there is a way to manually install from Github but it also requires settings up external apps/libs. So I would need more details from you.

If they are using standard Gnome Panel Menu layout, it should work OK else there can be some issue. Quick glance shows that it maybe standard layout, though I will look more into their code but without test it is difficult. Another reason could be that they have an override for style e.g. margin which they indeed seem to have in their settings/preferences. So in that case, have you tried to adjust it from their settings?

Also, to narrow down, please report your Open Bar settings for Bar Margin and Vertical Padding.

Thanks.

MarsSwimmer commented 9 months ago

thank you for your message!

the global menu extension is "fildem", author doesn't support update anymore, but there is someone fork it and update it for gnome45 (ubuntu 23.10), you can install follow these steps:

first, install fildem deb in your system, link: https://github.com/gonzaarcr/Fildem/releases/tag/0.6.7, asserts: fildem_0.6.7_all.deb, and add it to autostart.

second, install fildem extensions in a special way, just like this: git clone https://github.com/Sominemo/Fildem-Gnome-45.git cd Fildem-Gnome-45 cp -r fildemGMenu@gonza.com ~/.local/share/gnome-shell/extensions/

fildem update for gnome45 repo: https://github.com/Sominemo/Fildem-Gnome-45

third, restart your computer.

neuromorph commented 9 months ago

Thanks for the instructions and also about reporting the other extension. Though the issue in them may not be same.

Also, can you please check and update about following:

Another reason could be that they have an override for style e.g. margin which they indeed seem to have in their settings/preferences. So in that case, have you tried to adjust it from their settings? Also, to narrow down, please report your Open Bar settings for Bar Margin and Vertical Padding.

MarsSwimmer commented 9 months ago

Thanks!

My open bar settings margin:0 vertical_padding:4

I found sometimes menubar show correctly, it has vertical padding, and every menu button has horizontal margin (not zero), just like this: 1

But when I switch window menu bar style change to wrong style, 2

I really like open bar extension, and I know it must be style override problem on global menu, I have try to fix these style bugs on fildem extension, but failed, so sad...

Best regard!

neuromorph commented 9 months ago

Thank you for more details. I am not able to install it locally at this point so inputs from you do help. Again, as I suspected, it is not a margin issue but instead a padding issue. I looked again into Global Menu and saw that they have settings for horizontal padding. Their setting for horizontal padding will take preference and so you should set it from their extension settings. They don't seem to care about vertical padding, so it should not have created an issue but seems it does. I will check if I can find why vertical padding is in conflict. However, I have a solution for you. Since you are using 'Trilands' bar type, you can get the same effect as you wish without using Vertical padding in Open Bar. Do this:

That's it. With this, you should get the same style without this issue. Let me know how it goes.

MarsSwimmer commented 9 months ago

Thank you for you reply,

I have try to add vertical padding on fildem extension, but it doesn't work.

And I follow your method to setting open bar, now I have two style,

  1. menu button without margin 1

  2. menu button with margin 2

they both pretty beauty, thanks again, very light extension, I really like it.

Best regard!

neuromorph commented 9 months ago

You are welcome. Yes, your styles are looking good. Thanks for the update. A new version of Open Bar is submitted for review, you should get it soon, stay tuned!