neuromorph / openbar

A GNOME Shell extension for theming Gnome Top Bar / Top Panel, Menus, Dash/Dock, Gnome Shell and Gtk/Flatpak Apps.
https://extensions.gnome.org/extension/6580/open-bar/
GNU General Public License v3.0
268 stars 4 forks source link

Does Nothing #2

Closed in4matix closed 11 months ago

in4matix commented 11 months ago

Not sure if I'm missing something, but it does not work at all?

neuromorph commented 11 months ago

Hello Danny,

Please provide more details. I will need to be able to reproduce the issue you are facing so it can be fixed.

Note: For Menus, next version will provide better support

in4matix commented 11 months ago

Hello,

I'm on Ubuntu 22 LTS - Gnome 42.9 . Extension is enabled. Also use Blur My Shell Extension.

Screenshot from 2023-12-15 10-18-01 Screenshot from 2023-12-15 10-18-13 Screenshot from 2023-12-15 10-18-29 Screenshot from 2023-12-15 10-18-39

in4matix commented 11 months ago

I have tried many different setting and even after logging out and back in, no changes. I also tried setting the Gnome shell to default using Tweak Tool.

neuromorph commented 11 months ago

I am also on Ubuntu LTS with G 42.9 so this is unexpected. Your extension settings seem fine. Also, you've tested with default gnome shell theme so custom theme shouldn't be an issue. In any case, not seeing any change in Top bar by changing the extension settings points mainly to the issue that the extension is Not enabled successfully. Run this command in terminal to see if extension appears in enabled list: gnome-extensions list --enabled

Then, disable the extension through some tool or with command gnome-extensions disable openbar@neuromorph and in the terminal run following command to monitor the logs journalctl /usr/bin/{gjs,gnome-shell} -fo cat

Now, enable the extension again using a tool or this command gnome-extensions enable openbar@neuromorph

Watch the log in the journalctl command tab. If you see any error for openbar, let me know.

in4matix commented 11 months ago

This is what I'm getting:

daniel@dkdt:~$ journalctl /usr/bin/{gjs,gnome-shell} -fo cat
Number Object : [4]
Number Object : [4]
Number Object : [4]
Number Object : [4]
Number Object : [4]
meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
Source ID 687165 was not found when attempting to remove it
Source ID 755588 was not found when attempting to remove it
Source ID 727674 was not found when attempting to remove it
Source ID 796339 was not found when attempting to remove it
meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed
JS ERROR: TypeError: btn.child.menu is null
resetStyle@/home/daniel/.local/share/gnome-shell/extensions/openbar@neuromorph/extension.js:75:21
updateStyle@/home/daniel/.local/share/gnome-shell/extensions/openbar@neuromorph/extension.js:173:14
updatePanelStyle/this.updateTimeoutId<@/home/daniel/.local/share/gnome-shell/extensions/openbar@neuromorph/extension.js:95:55
setTimeout/<@/home/daniel/.local/share/gnome-shell/extensions/switcher@landau.fi/util.js:14:5

^C
daniel@dkdt:~$ 

After disabling the extension again, I get this: Screenshot from 2023-12-15 13-25-26

After logging out and back in, the error clears.

in4matix commented 11 months ago

Screenshot from 2023-12-15 13-32-25

neuromorph commented 11 months ago

OK, that looks like a bug. The items in the panel are dynamic (they come and go) and so resetting is getting tricky as I am working on the next update. This issue is also related to the same. I will fix it in the next update.

Thanks for reporting! Leave it disabled for now and enable once you get notified of the update.

in4matix commented 11 months ago

Thanks for your assistance. Looking forward to the update.

neuromorph commented 11 months ago

Quick update: New version is almost ready in github g42-44 branch if you would like to try out (includes support for menus). I would like to do a bit more tests and then submit to Gnome extensions-web. Also, the Gnome review might take some time before it can be published. It should work fine but if you face any issues feel free to ping here. Note: the default settings may not be good, as I haven't specifically set them yet (likely to be mostly just white color :)

neuromorph commented 11 months ago

Update: I have added more finishes and fixes in git and it is ready. Let me know if you try it out. I will iron out, in case any issues and then submit to Gnome extensions.

Thank you.

neuromorph commented 11 months ago

New version is up now in Extensions web. You should also get an update notification from the Extensions app of Glass Grid. Thus, I am closing this issue as resolved, if you face any problems please raise a new issue. Thanks!