search

neuromorph / openbar

A GNOME Shell extension for theming Gnome Top Bar / Top Panel, Menus, Dash/Dock, Gnome Shell and Gtk/Flatpak Apps.
https://extensions.gnome.org/extension/6580/open-bar/
205 stars 3 forks source link

Perfomance in Fullscreen with Dash to Dock #27

Closed NotMephisto closed 5 months ago

NotMephisto commented 6 months ago

How to reproduce it:

  1. Install Dash to Dock
  2. Turn it on and go to an app that opens fullscreen
  3. Exit or minimize it

Distro: Nobara 39 Gnome 45.5

Note: I dunno which settings cause this

Screencast from 2024-04-07 17-17-46.webm

neuromorph commented 6 months ago

Thank you for reporting! I was able to reproduce the issue after some meddling. There are multiple sources at play contributing to it:

However, the main culprit is a 'wait' added to Open Bar for issue #20 (to allow extensions like Fullscreen Avoider to move the panel when in fullscreen). And the reason for that is the fact that Open Bar removes styling of bar when in fullscreen. And the root cause of all this is some issue in mutter which (used to?) cause Gnome shell to crash if an extension alters the panel and user locks the screen while in fullscreen. Good news is that, I am unable to reproduce the crash now and so it seems it has been fixed upstream. This issue affected all extensions that style the panel e.g. Blur my shell which still has the issue open.

So, I have made it optional to keep or remove style in fullscreen. There is a new toggle in settings under Bar Props for 'Apply in fullscreen'. You should turn it On and your performance issue should go away. You need to get that update first. The update is currently in Github ('main' branch for Gnome 45+). You will need to manually install. You can just download and overwrite these files with those from Github:

Please also confirm the crash issue is fixed by trying these steps:

You should go to lock screen without any crash.

If all is well let me know. The next official update/release will include these fixes. I am working on more theming options, so it may take a while.

NotMephisto commented 5 months ago

Same issue after manually installation, If you don't have this problem, that means I have a problem specifically with Gnome/Mutter on my version or you need to do something that cause this issue but I haven't mentioned it. So, I should figure out what causes this problem, reproduce this again and report result!

P.S. Sometimes I have problem with animations switching between workspaces.

neuromorph commented 5 months ago

Did you do this after manual installation:

There is a new toggle in settings under Bar Props for 'Apply in fullscreen'. You should turn it On and your performance issue should go away.

This particular issue should get fixed with above steps. The workspace animations could be a different issue. I still have some ironing out to do about Overview/WindowMax-Bar/Fullscreen/Workspaces behavior (due to recent code change). I will let you know once I update that code in GitHub.

NotMephisto commented 5 months ago

Did you do this after manual installation:

There is a new toggle in settings under Bar Props for 'Apply in fullscreen'. You should turn it On and your performance issue should go away.

This particular issue should get fixed with above steps. The workspace animations could be a different issue. I still have some ironing out to do about Overview/WindowMax-Bar/Fullscreen/Workspaces behavior (due to recent code change). I will let you know once I update that code in GitHub.

No, I didn't. This option fix that issue. Sorry for misinformation and thanks!