neuromorph / openbar

A GNOME Shell extension for theming Gnome Top Bar / Top Panel, Menus, Dash/Dock, Gnome Shell and Gtk/Flatpak Apps.
https://extensions.gnome.org/extension/6580/open-bar/
GNU General Public License v3.0
128 stars 2 forks source link

[BUG]: Bar height to 0 then up again causes crash #53

Open balintbarna opened 4 days ago

balintbarna commented 4 days ago

Describe the bug The entire gnome session crashes and you're thrown back to the log in screen.

To Reproduce Steps to reproduce the behavior: Set the top bar bar height to 0 with your scroll wheel, then up to 1-2-3-4-5, etc. I'm not sure about the reproduction rate but it happened to me a few times.

Relevant Specs:

neuromorph commented 3 days ago

Good catch! Thank you for reporting!

Bar height of zero wouldn't fair well when Gnome's allocating it and can cause weirdness as you try to change it. I was able to reproduce the crash and it showed a memory access issue - segmentation fault. I have restricted the min height to 10 now since it is also already too low. I've also adjusted some timeout to avoid too many successive events when it is changed in that manner.

Works fine in my test so please try it out.

Note: The nixfix branch is now merged into main along with all the fixes. So please install from main branch.