search

neuromorph / openbar

A GNOME Shell extension for theming Gnome Top Bar / Top Panel, Menus, Dash/Dock, Gnome Shell and Gtk/Flatpak Apps.
https://extensions.gnome.org/extension/6580/open-bar/
GNU General Public License v3.0
268 stars 4 forks source link

[BUG]: Desktop Background Color Palette is inconsistent with the wallpaper(theme) switched by Night Theme Switcher #79

Open xcpky opened 1 month ago

xcpky commented 1 month ago

Describe the bug After night theme switcher switch the theme, the wallpaper changes, but the openbar doesn't update Desktop Background Color Palette. I've enabled all the autos.

To Reproduce Steps to reproduce the behavior:

  1. night theme switcher switch the themes and wallpaper

Relevant Specs:

neuromorph commented 1 month ago

Hello,

I just tried with Night Theme Switcher. It basically changes the Dark/Light mode as per set time. If you have different wallpapers set for Dark/Light then the wallpapers will also change. OpenBar does change the color palette accordingly as well. Demo tried with Fedora 41 in VM

One thing to note, both Dark/Light mode background images should be set when you click on Apply Autotheme in OpenBar. Basically, when OpenBar computes autotheme, it does so for both the backgrounds (if available) and saves them, and then when only the mode changes, it will switch the style/colors accordingly. The autotheme is recomputed when background changes but not recomputed when only the mode changes from Dark to Light or vice versa.

If you have kept, "Auto Refresh theme on background change" then it should recompute theme when you set new backgrounds (for both Dark and Light).

Let me know what exactly are you facing.

Thanks for reporting!

xcpky commented 1 month ago

it seems this is the process to reproduce:

  1. enable night theme switcher
  2. at night, the gnome is in dark theme
  3. screen locks
  4. the next morning, when I log back in from screen lock, the theme and wallpaper is switched to light theme, but the color palette is not updated.
neuromorph commented 1 month ago

OK, that's why!

On lock screen OpenBar gets disabled so it does not know when the Dark/Light mode or wallpaper has been changed by Night Theme switcher.

I will look into a workaround to check if that's the case when OpenBar is enabled.

neuromorph commented 1 month ago

I have added a fix to this issue in GitHub main branch. You can get the updated extension here - openbar@neuromorph Please install manually from there - (replacing extension.js and stylesheets.js should do)

You will need to log out and log back in after the change.

Let me know if it works. Thanks!