neuromorphs / tonic

Publicly available event datasets and transforms.
https://tonic.readthedocs.io
GNU General Public License v3.0
208 stars 47 forks source link

AugDiskCachedDataset to map the copy index to augmentation parameter #274

Closed MinaKh closed 5 months ago

MinaKh commented 11 months ago

This branch added a child class for DiskCachedDataset called AugDiskCachedDataset. Its main use is for a family of so-called deterministic augmentations with a rather discrete parameter space. For instance a noise augmentation on audio samples in which SNR can have only 5 values.

biphasic commented 11 months ago

Hello @MinaKh! Currently I don't understand how what you're trying to achieve with this class cannot already be done with existing classes. It seems to me that you want to control the augmentations exactly, but then I don't understand why they're called augmentations. Can you please

Before I can merge this, this class would need a test as well, it might be helpful to add that as well.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (db13037) 76.80% compared to head (c9d26b0) 77.34%. Report is 12 commits behind head on develop.

Files Patch % Lines
tonic/cached_dataset.py 58.69% 19 Missing :warning:
tonic/audio_transforms.py 92.00% 2 Missing :warning:
tonic/audio_augmentations.py 98.78% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #274 +/- ## =========================================== + Coverage 76.80% 77.34% +0.53% =========================================== Files 53 54 +1 Lines 3001 3165 +164 =========================================== + Hits 2305 2448 +143 - Misses 696 717 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MinaKh commented 10 months ago

Hello @MinaKh! Currently I don't understand how what you're trying to achieve with this class cannot already be done with existing classes. It seems to me that you want to control the augmentations exactly, but then I don't understand why they're called augmentations. Can you please

  • provide an example of how you use your proposed class
  • explain with a concrete example why the current code cannot do what you need to do

Before I can merge this, this class would need a test as well, it might be helpful to add that as well.

Hi @biphasic! Thanks for your feedback.