neuron-team / vscode-ipe

Interactive programming experience for data scientists: Visual Studio Code extension
MIT License
353 stars 27 forks source link

"Cannot find module 'vscode-ipe-types'" after preparation of the development environment #168

Closed MarcSkovMadsen closed 5 years ago

MarcSkovMadsen commented 5 years ago

Hi

I would try playing around with the extension and maybe implement some improvements if possible. But after

  1. I've cloned the project to my local machine
  2. I've followed the developer guide wrt. the section "Preparing the development environment"

The VS Code shows me the error Cannot find module 'vscode-ipe-types Cannot find module 'vscode-ipe-types' image.

If possible please let me know how to solve this and update the developer guide accordingly.

Thanks - any help is very much appreciated.

MarcSkovMadsen commented 5 years ago

I believe the problem is that a module called vscode-ipe-types should be installed under the node_modules folder but is not.

I believe the contents of the vscode-ipe-types folder should be the files found in the src-common/out folder

You can see that the vscode-ipe-types module is not listed in the vscode-ipe/node_modules folder below

image src-common/out folder.

Instead there is a module called neuron-ipe-types

image

MarcSkovMadsen commented 5 years ago

One solution is to replace all references to 'vscode-ipe-types' with 'neuron-ipe-types'.

image

MarcSkovMadsen commented 5 years ago

An alternative solution would be to change the "build-types" script in the package.json file from "build-types": "tsc -p src-common/ && shx cp -r src-common/ node_modules/neuron-ipe-types/",

image

to "build-types": "tsc -p src-common/ && shx cp -r src-common/ node_modules/vscode-ipe-types/",

image

This also solves the problem.

MarcSkovMadsen commented 5 years ago

I believe the first solution is the best i.e. keeping the module name as neuron-ipe-types as neuron is the name of this project/ add-in.

I will go ahead and create a branch for fixing the issue and create a pull request.

LukeyQ1 commented 5 years ago

The extension was renamed from vscode-ipe to neuron-ipe (the repo will also be renamed at somepoint) however i believe all these renames were fixed. If I look at the latest version of the files they all have the correct name. Are you sure you have the latest version of the repo?

pavanagrawal123 commented 5 years ago

I have the latest version of the repo and I'm experiencing the same issue

LukeyQ1 commented 5 years ago

Use the 1.0.3 pull request branch

pavanagrawal123 commented 5 years ago

Ahh I see I was just about to comment that the PR wasn't merged. I was wondering why it wasn't merged, is the project not being worked on actively any more?

MarcSkovMadsen commented 5 years ago

Ok. I will use the 1.0.3 pull request branch.

When can we expect the 1.0.3 pull request branch to be merged into master?

I would also like to know whether this is project is being maintained or not ?? Thanks :-)

LukeyQ1 commented 5 years ago

To answer @pavanagrawal123 question are quote what I wrote in another issue thread

I would love to work on this feature however it has been hard to find the time to work on the extension recently :( If anyone has a solution to this issue and would like to contribute please let me now. If there are any further developments I will update you

pavanagrawal123 commented 5 years ago

@LukeyQ1 I'm considering forking the plugin if there isn't too much activity in the PRs.

I really like this plugin and would like to fix the issues.

LukeyQ1 commented 5 years ago

I'm currently trying to move the repo to @neuron-team and when this is done the 1.0.3 PR will be merged and it will be easier to accept pull requests such as @pavanagrawal123 . I'm currently waiting on @lorenzo2897 to move the repo.

Again I'm sorry that work has stopped on the project for now but a few of us are eager to work on it when we get the time. I can't imagine there being any other update on our end until around December at the earliest :(

pavanagrawal123 commented 5 years ago

@LukeyQ1 sounds good. I have already forked to github.com/pavanagrawal123/VSNotebooks, but let's see how far the fork diverges before December!