search

neuronalmotion / qtrpi

An easy-to-use environment to cross-compile Qt applications for Raspberry Pi from your desktop.
MIT License
104 stars 40 forks source link

Adding qtgraphicaleffects into qt-modules.txt #66

Closed rahuldevikar761 closed 7 years ago

rahuldevikar761 commented 7 years ago

Adding qtgraphicaleffects into qt-modules.txt worked for me.

synapticvoid commented 7 years ago

Hi @rahuldevikar761 ,

I don't see any file change in your PR, can you please update it so I can review the content?

rahuldevikar761 commented 7 years ago

I have updated the qt-moodules.txt with qtgraphicaleffects.

I updated the module and ran the init-qtrpi-full.sh script and worked for me.

synapticvoid commented 7 years ago

I think you forgot to include your commit in the PR (the PR states that you didn't change any file), are you talking about this one https://github.com/rahuldevikar761/qtrpi/commit/5578d836193df4c2d4a2ac68a98948b9b4d4817b ?

If so, please update the PR so I can properly review it.

rahuldevikar761 commented 7 years ago

I did commit and pushed on a git. Also, I don't have a write access to this repository.

synapticvoid commented 7 years ago

I think you have to recreate a PR with this commit so I can properly merge it.

Please submit this new PR to be merged to the develop branch.

rahuldevikar761 commented 7 years ago

Did that worked?

GuillaumeLazar commented 7 years ago

The PR is empty, I close it.