Open MoJo2600 opened 3 years ago
Hello Christian,
Wow thanks a lot for this awesome contribution! I've skimmed through your changes and it looks very promising. Ping me again when you have stabilized your changes and I'll gladly review and test your PR.
We might have some back and forth about a few fixes but I definitely want to merge your work :+1: !
Yes, it is very crude right now, as I just figured out how everything is working. Have to do some cleanup later. I managed to build my intended application welle.io and it is running on my raspberry so the build is definitely working.
Okay, i did some cleanup and removed the requirements for welle.io. I tested it with rpi3 and 5.12.9. I will try to compile the old QT versions tomorrow. But I think we can start to talk about the fixes you mentioned.
I'd like to hear your opinion about docker builds, but i moved this to an issue so maybe I can add this after the merge.
Alright, I've reviewed the change set. If you could do some minor tweaks, it would be perfect:
docker/build.sh
README.md
with the commands to build the Docker image-j
flags on the make
commands. It was my mistake, but it's actually useless, because omitting it will not limit the number of jobsAfter that, I'll merge your PR and I'll take the time to clean up the repo to refer to the Docker build as the main one. Again, thanks for sharing your work :)
I will update the README tomorrow
I'm trying to compile welle.io for raspberry pi and stumbled upon this great project. But I want to compile it with 5.12 LTS. I adjusted your code to work, but right now I'm only focusing on Raspbery Pi 3, only full init and disregarded backward compatibility right now, hence WIP.
My current status is:
Still working on it