neuronets / nobrainer

A framework for developing neural network models for 3D image processing.
Other
158 stars 45 forks source link

Redundancy in serializing shapes of feature and label volumes #312

Open hvgazula opened 7 months ago

hvgazula commented 7 months ago

Referring to https://github.com/neuronets/nobrainer/blob/902a124f34b03f18212c25754a2f2d4ea9b35760/nobrainer/tfrecord.py#L197-L203 and https://github.com/neuronets/nobrainer/blob/902a124f34b03f18212c25754a2f2d4ea9b35760/nobrainer/tfrecord.py#L230-L235

why do we serialize the shapes individually when the array could be serialized?

Check if this has to do with https://github.com/neuronets/nobrainer/blob/902a124f34b03f18212c25754a2f2d4ea9b35760/nobrainer/tfrecord.py#L146-L149