search

neuronets / trained-models

Trained TensorFlow models for 3D image processing
https://neuronets.dev/trained-models
22 stars 15 forks source link

Delete issue branch if workflow fails #108

Open hvgazula opened 11 months ago

hvgazula commented 11 months ago

Currently, the issue branch is retained in the remote repo and, (ideally) we want this branch to be deleted if the testing workflow fails. However, the key stumbling block is moving deletion into a separate job. For more info, see https://github.com/neuronets/trained-models/issues/104#issuecomment-1806672486

hvgazula commented 11 months ago

Edward, do you think can look into this?

gaiborjosue commented 11 months ago

Hello @hvgazula to make sure I understand this, do you want to delete the branch created in the repo if either singularity or docker fails?

hvgazula commented 11 months ago

as the title suggests...if the workflow fails..

gaiborjosue commented 11 months ago

Okay 👍Would you agree to perform this on the already existing 'failed' job?

hvgazula commented 11 months ago

before that I want you to look at my workflow and tell what can fail...if it has any loopholes that I did not address but you did in yours.

gaiborjosue commented 11 months ago

Sure, I am creating comments on your PR

gaiborjosue commented 11 months ago

Hello @hvgazula, deleting the branch if fails is implemented: https://github.com/neuronets/trained-models/blob/hvgazula/issue104/.github/workflows/new_model.yml#L334

I tested it out and it worked.