Closed gaiborjosue closed 1 year ago
My above recommendation will also ensure that all models users try to add do not use other path flags for their scripts.
i.e DeepCSR-fork model requires for a config file to be given as a flag; the config file contains a lot of parameters for model performance/qualities. Thus, DeepCSR-fork can't be added to the zoo as it now requires an extra path other than weights and sample data.
The reason for this is that there is no way of us to know what extra files (as config) each single model requires.
In addition to my recommendation, I would say that another way to approach it may be to ask users for a "Test-command" and allow them to include all the flags for weights and sample data. However, the path added to those flags should be relative to the repo's directory structure.
For example,
python ./DeepCSR/deepcsr/1.0/predict.py --weights ./DeepCSR/deepcsr/1.0/weights/best_model.pth --sampledata ./DeepCSR/deepcsr/1.0/example-data/sample.nii.gz --height 53 --width 40 ...
See how the path follows the org/model/version directory structure instead of a local absolute path.
Hello,
I am considering adding a field "Test-command" in the upcoming issue-form workflow to add a new model to this repo.
This is because to test the Python scripts, we need to know how to run those scripts. If we use spec.yaml for that, it contains placeholders for the path, such as "{infile[0]}"
So, I suggest adding a new input text field so that users input how to run their predict.py file (it can be called whatever name) without any flags containing the paths.
For example, the user would input:
python predict.py --length 15 --height 50
This will enable us to manually add the paths to the weights and sample dataset while testing, following our directory structure as suggested by @hvgazula.
For example, we will addon the following paths:
python predict.py --length 15 --height 50 --weights ./Model/best_model.pth --sampleDataset ./Model/test.nii.gz
This way, the user only gives the barebone test command to the script, and we worry about adding paths automatically.
Thanks.