Closed gaiborjosue closed 1 year ago
Impressive. Thank you very much for all your efforts @gaiborjosue 👍. Now, let's wait for @satra's feedback.
i'm fine with implementing these. however, i would urge to create an MVP that adds models even if they fail for various compatibility issues. i.e. get models that work in and tell users about models that don't work. that's all that is needed. leave compatibility to the user, just tell them what environment things are running in.
I have two models that are ready to be pushed to the repo. Will give it a try next week. @gaiborjosue Let's schedule a time next week to do one.
@hvgazula of course👍
@gaiborjosue If you don't mind, can you be a little more descriptive with your commit messages (if possible)? I mean you already are, but just the testing
, testing2
, and fixed_update
weren't very informative.
Hello @hvgazula, yes. Sorry about that. Since some of them are very small changes requiring a commit to sync with the workflows, I do small messages. I will dedicate a few more seconds to better commits. Thank you for the feedback.
Hello @hvgazula, the docs are updated, and workflows are tested.
General changes since the last update:
Thanks, Edward
Hello @hvgazula, I added comments on file id extraction 👍
Hello @hvgazula, nice. Now we need to add the env variables and secrets. This should be related to Ec2 and a github token with issue and workflow permissions.
Please email me all the relevant information. Thanks.
Hello,
This pull request will close #76 close #80 close #81 and close #64
This enhancement or new feature uses GitHub issue forms to enable users to submit a new model more easily and automatically. Check how the templates look here: https://github.com/gaiborjosue/trained-models-fork/issues/new/choose
You can find the workflow as .github/workflows/new_model.yml
This means that the new workflow will provide enhancement for:
Next, I will attach a flow chart describing a synthesized version of the workflow since it has +500 lines:
As described above, the user will create an issue form. The action will run. If it fails, it will tag the issue as failed, and the user will have to fix issues and then change the label to "Ready-to-test" for the workflow to trigger and test again.
During these processes, the workflow also has metric tracking and useful performance insights that users may check during the workflow execution in the specific Job Summary. i.e.
@satra This new feature is 100% tested with a testing model, 'DeepCSR.'
However, a few steps are missing before this PR is/should be merged. We are working on these and will finish them as fast as possible. Perhaps @hvgazula can provide more insights into some of the following steps:
As mentioned, the "Add a new model" feature is 100% ready :). There are just a few steps before this PR can be merged. Edit: I forgot to attach the testing run of the workflow which succeeded: https://github.com/gaiborjosue/trained-models-fork/actions/runs/6442779018