neuronets / trained-models

Trained TensorFlow models for 3D image processing
https://neuronets.dev/trained-models
22 stars 15 forks source link

fix(Singularity&Datalad): Fixed command #99

Closed gaiborjosue closed 1 year ago

gaiborjosue commented 1 year ago

This will close #96 close #95 close #93

This also purges useless steps in the workflow.

hvgazula commented 1 year ago

Aren’t these changes needed for update_model.yml as well?

On Wed, Nov 1, 2023 at 10:09 AM Edward Gaibor @.***> wrote:

@.**** commented on this pull request.

In .github/workflows/new_model.yml https://github.com/neuronets/trained-models/pull/99#discussion_r1378851457 :

@@ -250,38 +250,14 @@ jobs: MODELNAME: ${{ steps.set_image_name.outputs.model_name }}

 steps:

Hi @hvgazula https://github.com/hvgazula, as you can see, its in the step build-docker which is not in the ec2 instance. Thus, the only thing that is being executed in that step is the name extraction for the image. So, there is no need to clean space in that step. Which would save around 5-10minutes of the action workflow.

— Reply to this email directly, view it on GitHub https://github.com/neuronets/trained-models/pull/99#discussion_r1378851457, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHXDP6V3L6323TNABPZZITYCJJZXAVCNFSM6AAAAAA6YUBQHOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBYGMYDGNBTGI . You are receiving this because you were mentioned.Message ID: @.***>

gaiborjosue commented 1 year ago

Yes 🤦‍♂️ I will update them as fast as possible.

gaiborjosue commented 1 year ago

@hvgazula, code is updated.