Various CI fixes - Githubissues

iomaganaris commented 10 months ago

Use nrn_requirements.txt and ci_requirements.txt to install the necessary python packages for the NEURON installation
If ci_requirements.txt doesn't exist (NEURON 8.2.3) then just install the current packages listed in it
Install the NMODL required packages from external/nmodl/requirements.txt
Upgrade from MacOS 11,12 to 12, 13
Install setuptools for Python 12 support
Recursively clone submodules

TODO

[x] Port https://github.com/neuronsimulator/nrn/pull/2193 to NEURON 8.2.3 to enable Python 3.12 support (handled in https://github.com/neuronsimulator/nrn/pull/2663)
[x] fix segfault in Python 3.12 (fixed in https://github.com/neuronsimulator/nrn/pull/2695)

JCGoran commented 10 months ago

LGTM, now I think we just need to wait for a 8.2.x release which has full Python 3.12 support, after which we can merge this.

pramodk commented 10 months ago

Asking for clarity: As 8.2.x tag/release could take some time (week[s]), do we have any other option to get this merged sooner and make CI green? i.e. using python 3.11 or MacOS-13 Or stick to MacOS 11 & 12 for some time?

JCGoran commented 10 months ago

In principle it should be doable as the MacOS runners come with a cached version of Python 3.11 (see for instance here), but I'm not 100% sure how to modify the CI config file to make it pass for all cases (tried using setup-python but it didn't work as expected as the run failed, I think it should setup different versions of Python depending on the runner and not just use the same version for all of them).

neuronsimulator / nrn-build-ci

Various CI fixes #62

TODO