search

neuronsimulator / nrn-modeldb-ci

NEURON ModelDB CI tools
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Run only changed models on PR if the `modeldb-run.yaml` file has changed #104

Closed JCGoran closed 10 months ago

JCGoran commented 10 months ago

It would be extremely useful if, when opening a PR that only affects the modeldb-run.yaml file, the CI would run runmodels for either:

Rationale: currently, to figure out whether a fix for a model works, it requires us to manually run the GH action, which can be error-prone and is very tedious. Comparing with the parent commit we can figure out the difference, and then the modeldb-run.yaml file could be parsed using something like pyyaml to figure out which models that difference has an impact on, which could be fed directly to runmodels.

alexsavulescu commented 10 months ago

You can specify MODELS_TO_RUN in the PR description: https://github.com/neuronsimulator/nrn-modeldb-ci/blob/master/.github/workflows/nrn-modeldb-ci.yaml#L117

JCGoran commented 10 months ago

Oh neat! Would be great if this was document somewhere other than the CI file itself though.