search

neuronsimulator / nrn-modeldb-ci

NEURON ModelDB CI tools
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Filter output from 180373 #107

Closed JCGoran closed 7 months ago

JCGoran commented 7 months ago

The call to <Vector>.plot in Fig3A.hoc outputs Vector[<int>] to stdout which does not seem to have an impact on the results. Verification: https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/7626068663

pramodk commented 7 months ago

Just for context, copying @JCGoran's comment from Slack here:

the last model to fix is https://github.com/ModelDBRepository/180373, with the somewhat short diff:

--- /home/runner/work/nrn-modeldb-ci/nrn-modeldb-ci/8.2.3/180373/ShaiEtAl2015

+++ /home/runner/work/nrn-modeldb-ci/nrn-modeldb-ci/9.0a-133-gd59d45865/180373/ShaiEtAl2015

@@ -46,9 +46,9 @@

    0 
    0 
    1 
-   Vector[2132] 
+   Vector[2133] 
    1 
-   Vector[2133] 
+   Vector[2134] 
    1 
    1 
    1

i.e. something related to vector length is different / changed. But if the results are same, we can ignore this difference between 8.2* and 9.0/master/