search

neuronsimulator / nrn-modeldb-ci

NEURON ModelDB CI tools
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

fix 150245 pattern replace #114

Closed nrnhines closed 6 months ago

nrnhines commented 6 months ago

The change in random for 150245 changed the number of spikes which requires a change in a pattern replace line in modeldb-run.yaml

pramodk commented 6 months ago

@nrnhines : CI is still failing?

nrnhines commented 6 months ago

@nrnhines : CI is still failing?

I'm not sure what is failing. Perhaps it has to do with neuronsimulator/nrn#2764 not yet being merged. I'll look at 138379 tomorrow

nrnhines commented 6 months ago

@nrnhines : CI is still failing?

I'm afraid I'm at a loss. 138379 is working on my machine (it is one of the models that needed Random123 changes) and the change I made to modeldb-run.yaml is present in this PR.

138379:
    github: "pull/3"
    ...

$ nrniv --version NEURON -- VERSION 8.2.4 HEAD (1d87d5d39) 2024-02-09 $ runmodels --workdir temp8.2.4 --clean --virtual --gout 138379

$ nrniv --version NEURON -- VERSION 9.0a-170-ged09605ab master (ed09605ab) 2024-02-26 $ runmodels --workdir temp1 --clean --virtual --gout 138379

$ diffreports2html temp8.2.4.json temp1.json Writing /home/hines/neuron/nrn-modeldb-ci/temp8.2.4-vs-temp1.html ... Done. Writing /home/hines/neuron/nrn-modeldb-ci/runtimes-temp8.2.4-vs-temp1.html ... Done.

nrnhines commented 6 months ago

In the CI Details

1s
Run diffreports2html ${nrn[1](https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/8071238317/job/22050435286?pr=114#step:12:1)_ver}.json ${nrn2_ver}.json
Writing /home/runner/work/nrn-modeldb-ci/nrn-modeldb-ci/8.2.4-vs-9.0a-[17](https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/8071238317/job/22050435286?pr=114#step:12:18)0-ged09605ab.html ...
Done.
Writing /home/runner/work/nrn-modeldb-ci/nrn-modeldb-ci/runtimes-8.2.4-vs-9.0a-170-ged09605ab.html ...
Done.
FAILURE: stdout diffs in {'138379'}
Error: Process completed with exit code 1.

How would one view the

/home/runner/work/nrn-modeldb-ci/nrn-modeldb-ci/8.2.4-vs-9.0a-170-ged09605ab.html

The url after that filename is just the current page.

nrnhines commented 6 months ago

Found it in the artifacts. image So I guess another pattern/replace line is needed to get rid of the Matplotlib line.

nrnhines commented 6 months ago

So I guess another pattern/replace line is needed to get rid of the Matplotlib line.

Or would it be better to install the Matplotlib font cache during setup? How would that be done?

Seems that the warning could be suppressed with

import matplotlib; matplotlib.set_loglevel("critical")

I guess I prefer just pattern/replacing the line in the modeldb-run.yaml file.