search

neuronsimulator / nrn-modeldb-ci

NEURON ModelDB CI tools
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

diffreports2html: add curate patterns per model id #17

Closed alexsavulescu closed 2 years ago

alexsavulescu commented 2 years ago

Some models have diffs that we wouldn't really want to pay attention to: image

We could consider adding curate_patterns: - to the https://github.com/neuronsimulator/nrn-modeldb-ci/blob/master/modeldb/modeldb-run.yaml and use it in curate_run_data https://github.com/neuronsimulator/nrn-modeldb-ci/blob/master/modeldb/report.py#L12

nrnhines commented 2 years ago

Hard to say without analysis. At first glance it appears the first difference is the return value of rdm.uniform(0,0.3) which is using

rdm = new Random()
rdm.MCellRan4()

and MCellRan4 is presumably deterministically reproducible. As for TMAX, that is tmax_INTF and my guess for that is that it is the last integrate and fire time for ARTIFICIAL_CELL INTF. But you're right. I'm not sure its worth summoning the energy to deal with this case.

alexsavulescu commented 2 years ago

Thank you for the input Michael. As far as I see things, curation (either for model launching or for outputs) should be part of ongoing efforts. And we should document/add comments while doing so.