search

neuronsimulator / nrn-modeldb-ci

NEURON ModelDB CI tools
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

MDB_MODEL_DOWNLOAD_URL needs to be updated #82

Closed ramcdougal closed 1 year ago

ramcdougal commented 1 year ago

In modeldb/modeldb.py, MDB_MODEL_DOWNLOAD_URL is set to pull from the Yale site. This link will become inoperative at somepoint in June.

Instead of pulling all the data and metadata about a model to get the file contents, going forward download_model can get the file contents direclty via links of the form https://modeldb.science/eavBinDown?o={model_id}

alexsavulescu commented 1 year ago

The idea is to use GitHub to download models: https://github.com/neuronsimulator/nrn-modeldb-ci/pull/72

alexsavulescu commented 1 year ago

However we still have https://github.com/neuronsimulator/nrn-modeldb-ci/issues/71

olupton commented 1 year ago

To avoid the very-high-latency cache setup we have at the moment, we need a way of efficiently getting the list of models to be tested and some kind of last-updated timestamp or commit ID. I believe this is well within the limits of the GitHub API.

alexsavulescu commented 1 year ago

something like : https://github.com/neuronsimulator/nrn-modeldb-ci/issues/47#issuecomment-1232982673

olupton commented 1 year ago

Based on https://modeldb.science/api it looks like the results of https://modeldb.science/api/v1/models/id?modeling_application=NEURON and https://modeldb.science/api/v1/models/ver_date?modeling_application=NEURON could be zipped together to get a list of (id, date) pairs.

It seems "reasonable" to assume that these two queries will return results sorted by some common key, so it is safe to zip them together, but I don't see it documented that this is the case. Can you confirm @ramcdougal?

ramcdougal commented 1 year ago

Yes, the two responses are in the same order, and the API documentation on ModelDB.science has been updated to reflect this.