search

neuronsimulator / nrn-modeldb-ci

NEURON ModelDB CI tools
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

Improve .mod search strategy #89

Closed olupton closed 1 year ago

olupton commented 1 year ago

Should avoid having to explicitly set model_dir for models with a simple directory structure.

Unfortunately this exposes various models with .mod files that do not compile, which were previously missed because there was no model_dir setting and the .mod files were not at the top level.

The following 30 models are now skipped, because their .mod files do not compile: 7907 125385 144579 147141 154096 155735 155796 182134 183014 183718 184497 229585 230861 237469 239421 240116 246546 256311 261460 265523 266732 266799 266806 266864 267146 267189 267511 267587 267595 267646.

Additionally new model 241169 is not executed, because it makes invalid assumptions that break with neuron-nightly.

olupton commented 1 year ago

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/5354503218 is running with all models.

olupton commented 1 year ago

Launched https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/5356475106 with all models.

olupton commented 1 year ago

https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/5358611403 passed with all models and aff0e03d828e098db143a44cb3cf40970fc33a9e.