search

neuronsimulator / nrn-modeldb-ci

NEURON ModelDB CI tools
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

model id is occasionally different from the id of the zip file #95

Open nrnhines opened 1 year ago

nrnhines commented 1 year ago

NEURON implementation identifiers are not always identical to model entry identifiers. For example, the entry identifier for the 2005 Traub model is 45539 but the ifc fortran implementation is downloaded if that entry identifier is used for database download. This PR uses the NEURON implementation identifier instead of the entry identifier for

data.Model._object_id

A wrinkle is that a model entry identifier may have multiple distinct NEURON implementation identifiers.

Closes #94

It may be worthwhile to modify this PR so that data.Model._object_id continues to refer to the model entry identifier and add a data.Model._zip_id to refer to the id used for zip file download. Note that the ModelDB.metatdata dictionary now has NEURON implementation identifiers for keys. field to refer to the implementation identifier

nrnhines commented 1 year ago

Another implementation method, that makes the existing modeldb API more visible, is to have the modeldb-meta.yaml file additionally contain the "alternative_version" and perhaps the "modeling_application" fields. This might make the processing to determine the proper zip download url more clear.