search

neuronsimulator / nrn

NEURON Simulator
http://nrn.readthedocs.io
Other
401 stars 116 forks source link

NEURON 8.0's nrnivmodl should default to running modlunit #1026

Open ramcdougal opened 3 years ago

ramcdougal commented 3 years ago

Unit checking of mod files should be run by default during nrnivmodl compilation. (GUI compilation alternatives should do the same.)

This could be disabled with a flag for older mod files, e.g. --no-units-checking:

nrnivmodl --no-units-checking mod/

A major version bump is the time to make such a change, and impacts to older models could be minimized by having a clear error message mentioning how to disable units checking.

nrnhines commented 3 years ago

Good idea!

ramcdougal commented 3 years ago

It might be worth trying to check how many NEURON models on ModelDB would fail a modlunit check...

... but hopefully most of those just don't have units specified and there isn't anything wrong with the mod file per se... this is a potentially opportunity for curation and improved model quality either now or for the future.

EDIT: even if some models fail for other reasons, that's not a reason not to make this change.