search

neuronsimulator / nrn

NEURON Simulator
http://nrn.readthedocs.io
Other
378 stars 114 forks source link

Clean up `DOS` ifdef #2872

Closed mgeplf closed 2 months ago

mgeplf commented 2 months ago

From what I can tell, the DOS define wasn't being defined anywhere, and I couldn't find a compiler that defines it automatically.

I think it would be worth having @nrnhines to have a look, since he knows the history, and what this was originally intended for.

sonarcloud[bot] commented 2 months ago

Please retry analysis of this Pull-Request directly on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.19%. Comparing base (d99cbb5) to head (38b8867).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2872 +/- ## ========================================== + Coverage 67.18% 67.19% +0.01% ========================================== Files 564 563 -1 Lines 104268 104244 -24 ========================================== - Hits 70053 70048 -5 + Misses 34215 34196 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.