neuronsimulator / nrn

NEURON Simulator
http://nrn.readthedocs.io
Other
378 stars 114 forks source link

No need to precheck for ptr!=0 for free #2890

Closed alkino closed 1 month ago

alkino commented 1 month ago

From https://linux.die.net/man/3/free:

If ptr is NULL, no operation is performed.

azure-pipelines[bot] commented 1 month ago

✔️ 2d0728b8f4548244732722801f9ca0868c0ac216 -> Azure artifacts URL

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 67.22%. Comparing base (c6aea21) to head (86d311d). Report is 1 commits behind head on master.

Files Patch % Lines
src/nrnpython/rxd_extracellular.cpp 58.82% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2890 +/- ## ========================================== - Coverage 67.23% 67.22% -0.01% ========================================== Files 569 569 Lines 104713 104712 -1 ========================================== - Hits 70400 70392 -8 - Misses 34313 34320 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #214090 (:white_check_mark:) have been uploaded here!

Status and direct links:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 1 month ago

✔️ 86d311d034b2d32e1e20d195db731eee027de22c -> Azure artifacts URL

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #214388 (:white_check_mark:) have been uploaded here!

Status and direct links: