Add RxDExceptions to invalid arguments in _ensure_arithmeticed

neuronsimulator / nrn

NEURON Simulator

http://nrn.readthedocs.io

Other

395 stars 116 forks source link

Add RxDExceptions to invalid arguments in _ensure_arithmeticed #2893

Open rgourdine opened 4 months ago

rgourdine commented 4 months ago

Closes #2892

azure-pipelines[bot] commented 4 months ago

✔️ e4dd966e125ef73294d3aaf37c3fea948d24d227 -> Azure artifacts URL

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #214252 (:no_entry:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 4 months ago

✔️ b17da756e3ff64a4fe499e8c2923149e47d68211 -> Azure artifacts URL

azure-pipelines[bot] commented 4 months ago

✔️ 61f4eb23f7a1de15f2c8737766ab0ce62ab8a905 -> Azure artifacts URL

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #214279 (:no_entry:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 4 months ago

✔️ 5b816734a229a4bdd3b20f79cd0a9216157a03d7 -> Azure artifacts URL

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.39%. Comparing base (80a2c01) to head (fac6cb0). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2893 +/- ## ========================================== - Coverage 67.39% 67.39% -0.01% ========================================== Files 573 573 Lines 104927 104930 +3 ========================================== + Hits 70717 70718 +1 - Misses 34210 34212 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #214299 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #217294 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 3 months ago

✔️ 3da97d434558d0144beda97d2c7a934ee2683334 -> Azure artifacts URL

azure-pipelines[bot] commented 3 months ago

✔️ 0f304cda6edf24c0159054e21abca9c571d1ed80 -> Azure artifacts URL

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #217760 (:no_entry:) have been uploaded here!

Status and direct links:

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 3 months ago

✔️ 89fbbebe74c143ddf78f8ef509be1b13425c7461 -> Azure artifacts URL

ramcdougal commented 3 months ago

Does anyone have any intuition (1) why the data type would be reported as different on macOS with Python 3.12 than on everything else? Bonus: it reports as exactly what it should be, but isinstance fails. (2) Why librxdmath would be built for a newer macOS version than used in the CI? That just seems like it's asking for trouble.

@adamjhn @nrnhines @pramodk

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #218747 (:no_entry:) have been uploaded here!

Status and direct links:

pramodk commented 3 months ago

@ramcdougal: I don't have an idea for (1) but for (2) created https://github.com/neuronsimulator/nrn/pull/2944. I didn't check much details but I assume (2) is not causing any failures.

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 1 week ago

✔️ fac6cb07ccbf23901f5ab7de4938d09d334a71d2 -> Azure artifacts URL