Pin numpy max version to <2

neuronsimulator / nrn

NEURON Simulator

http://nrn.readthedocs.io

Other

376 stars 113 forks source link

Pin numpy max version to <2 #2916

Closed JCGoran closed 2 weeks ago

JCGoran commented 2 weeks ago

Numpy 2 is out, and consequently, most of the scheduled CI jobs broke due to binary incompatibility:

'from neuron import rxd' failed numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

As a workaround we can pin the version to numpy<2 everywhere.

pramodk commented 2 weeks ago

'from neuron import rxd' failed numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

cc'ing @ramcdougal @adamjhn

azure-pipelines[bot] commented 2 weeks ago

✔️ ee6052acbca7160431cd93ec2837177f93240bbd -> Azure artifacts URL

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

JCGoran commented 2 weeks ago

Note that the docs failing seems to be unrelated:

ModuleNotFoundError: No module named 'tenacity.asyncio'

Apparently the tenacity library had a recent update which changed the dir structure, see this diff, so I added an explicit pin of it (it's a dependency of plotly, but hasn't been fixed on their end yet).

azure-pipelines[bot] commented 2 weeks ago

✔️ 0e6463f4bfbec97d4c9ae5e950130514cc7aa2a7 -> Azure artifacts URL

azure-pipelines[bot] commented 2 weeks ago

✔️ f2bd65bc6d7dd9fd33c1a04b5ef49238fca69de3 -> Azure artifacts URL

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.21%. Comparing base (8c39669) to head (f2bd65b).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2916 +/- ## ========================================== - Coverage 67.21% 67.21% -0.01% ========================================== Files 569 569 Lines 104698 104699 +1 ========================================== Hits 70374 70374 - Misses 34324 34325 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 2 weeks ago

Logfiles from GitLab pipeline #217257 (:white_check_mark:) have been uploaded here!

Status and direct links: