Use `Py_RETURN_NONE` macro when return `Py_None`

neuronsimulator / nrn

NEURON Simulator

http://nrn.readthedocs.io

Other

376 stars 113 forks source link

Use `Py_RETURN_NONE` macro when return `Py_None` #2938

Closed mgeplf closed 1 week ago

mgeplf commented 1 week ago

for older pythons (ex: 3.8) it increments and returns: https://github.com/python/cpython/blob/3.8/Include/object.h#L564
In later version of python, since None is an immortal singleton, the right thing happens: https://github.com/python/cpython/blob/main/Include/object.h#L644

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 1 week ago

✔️ 3b12249956a13e92275761d2beb6a4738d87b314 -> Azure artifacts URL

codecov[bot] commented 1 week ago

Files	Patch %	Lines
src/nrnpython/nrnpy_nrn.cpp	66.66%	2 Missing :warning:

```diff @@ Coverage Diff @@ ## master #2938 +/- ## ======================================= Coverage 67.25% 67.25% ======================================= Files 570 570 Lines 104949 104933 -16 ======================================= - Hits 70580 70574 -6 + Misses 34369 34359 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 week ago

Logfiles from GitLab pipeline #218776 (:white_check_mark:) have been uploaded here!

Status and direct links:

neuronsimulator / nrn

Use `Py_RETURN_NONE` macro when return `Py_None` #2938

Quality Gate passed

Codecov Report