neuronsimulator / nrn

NEURON Simulator
http://nrn.readthedocs.io
Other
376 stars 113 forks source link

Fragments from 2dd4518 windows 11 fix for nrniv -python (#2255) #2946

Closed nrnhines closed 2 days ago

nrnhines commented 1 week ago

Picked the substantive changes from #2255 that should go into release/8.2. Tested on Windows11 virtualbox guest

azure-pipelines[bot] commented 1 week ago

✔️ f3962671959da5131831471faef23f45a5d7ee06 -> Azure artifacts URL

nrnhines commented 1 week ago

how do we format release/8.2?

clang-format --style=file:external/coding-conventions/cpp/clang-format-12 -I src/nrniv/*.cpp

changes every file in that folder.

sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nrnhines commented 2 days ago

Tested on windows11 and works. I notice that the artifact for the Windows Installer / WindowsInstaller (pull_request) CI did not build against python3.12 so tested with python3.11

nrnhines commented 2 days ago

I think this PR is ready to merge if the CI neuronsimulator.nrn Failing after 60m — Build #20240704.22 failed can be fixed.

azure-pipelines[bot] commented 2 days ago

✔️ b10b5688318e5cf76f11382f361607acfee1a1a6 -> Azure artifacts URL