neuronsimulator / nrn

NEURON Simulator
http://nrn.readthedocs.io
Other
376 stars 113 forks source link

Remove NMODL include directory dependency. #2953

Open matz-e opened 4 days ago

matz-e commented 4 days ago

In BlueBrain/nmodl#1329, solver includes for MOD file generation are included in the NMODL binary. This PR removes remaining CMake glue, as well as outdated code removed in BlueBrain/nmodl#964. Sitting on top of #2952.

Closes #2952.

CI_BRANCHES:NMODL_BRANCH=master

azure-pipelines[bot] commented 4 days ago

✔️ 04b42eca388f45fee5fe84a55507a9a341c338bd -> Azure artifacts URL

bbpbuildbot commented 4 days ago

Logfiles from GitLab pipeline #219825 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 days ago

Logfiles from GitLab pipeline #219824 (:no_entry:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 4 days ago

✔️ e073aa9242973a8e569db9979da021052107a808 -> Azure artifacts URL

bbpbuildbot commented 4 days ago

Logfiles from GitLab pipeline #219873 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 3 days ago

Logfiles from GitLab pipeline #220098 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 3 days ago

✔️ 964c33c29fd35e65a585c12470afe522ea12c277 -> Azure artifacts URL

azure-pipelines[bot] commented 3 days ago

✔️ fe549964a951a112f5b59213b20edbd61ea7c8b8 -> Azure artifacts URL

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.26%. Comparing base (4cdec23) to head (8be69ce). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2953 +/- ## ========================================== - Coverage 67.26% 67.26% -0.01% ========================================== Files 571 571 Lines 104874 104877 +3 ========================================== + Hits 70543 70544 +1 - Misses 34331 34333 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 3 days ago

Logfiles from GitLab pipeline #220185 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 days ago

Logfiles from GitLab pipeline #220250 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 2 days ago

✔️ 8c3ba45b8519ef3282a064881fff2b0c83648c3d -> Azure artifacts URL

bbpbuildbot commented 1 day ago

Logfiles from GitLab pipeline #220565 (:no_entry:) have been uploaded here!

Status and direct links:

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 1 day ago

✔️ 8be69ce6ab79f19ffb1488cad8689a2a19212cfd -> Azure artifacts URL

bbpbuildbot commented 1 day ago

Logfiles from GitLab pipeline #220572 (:white_check_mark:) have been uploaded here!

Status and direct links: