Install ONE requirements file with all requirements.

neuronsimulator / nrn

NEURON Simulator

http://nrn.readthedocs.io

Other

395 stars 116 forks source link

Install ONE requirements file with all requirements. #2955

Closed matz-e closed 3 months ago

matz-e commented 3 months ago

When installing NMODL requirements after the fixed numpy version, NMODLs lesser constrained dependencies take precedence over the currently installed packages.

This PR:

Will consider only the build dependencies of NMODL
Construct one requirements file with the merged requirements of NMODL, NEURON
Fix a setuptools requirement for Python 3.12 and Windows that broke with a newer version

ferdonline commented 3 months ago

Will it fix

Downloading numpy-1.26.0-cp312-cp312-macosx_10_9_x86_64.whl (20.3 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━        16.8/20.3 MB 4.5 MB/s eta 0:00:01
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes

matz-e commented 3 months ago

THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE

Can do by adding --no-cache-dir to the pip command.

matz-e commented 3 months ago

Actually --no-cache-dir would probably lead to a lot more downloads and longer runtime. Seems to me that the issue may also be truncated downloads - more a networking issue within the CI.

So the error may occur even more frequently if we don't cache...

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.25%. Comparing base (8ffa1fa) to head (470a4bc).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2955 +/- ## ========================================== - Coverage 67.25% 67.25% -0.01% ========================================== Files 571 571 Lines 104902 104902 ========================================== - Hits 70557 70550 -7 - Misses 34345 34352 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #220190 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 3 months ago

✔️ 233d9709a489256254fa3aef7248a51ad25b306f -> Azure artifacts URL

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 3 months ago

✔️ 470a4bc6601e64baed89e0044888b5bdf92738b1 -> Azure artifacts URL

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #220216 (:white_check_mark:) have been uploaded here!

Status and direct links:

JCGoran commented 3 months ago

Will it fix

Downloading numpy-1.26.0-cp312-cp312-macosx_10_9_x86_64.whl (20.3 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━        16.8/20.3 MB 4.5 MB/s eta 0:00:01
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes

For reference, I am about 99% sure it's this issue: https://github.com/pypa/pip/issues/11153 It happens intermittently, and is usually fixed by re-running the job.