neuronsimulator / nrn

NEURON Simulator
http://nrn.readthedocs.io
Other
381 stars 114 forks source link

Remove Perl dependency. #2960

Closed matz-e closed 1 month ago

matz-e commented 1 month ago

No real Perl functionality is required in NEURON, but it adds complexity to the build, and introduces yet another language.

For MacOS, starting with 12.3, readlink -f is supported. MacOS 11 aka Big Sur has reached the end of official Apple support in 2023.

pramodk commented 1 month ago

🎉

I will let @nrnhines take a look as he might know all corner cases from old days.

pramodk commented 1 month ago
error: IClamp mechanism does not exist
packaging/python/test_wheels.sh: line 98: 18770 Abort trap: 6           nrniv-core --datpath .

Wheel CI has the above. This indicates the mod_func.cpp is not generated properly i.e. additional mechanisms are not being registered properly.

matz-e commented 1 month ago

@pramodk is used some Bash 4 things that are not available on MacOS :facepalm:

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #220515 (:no_entry:) have been uploaded here!

Status and direct links:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.26%. Comparing base (79ad349) to head (3863174). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2960 +/- ## ========================================== - Coverage 67.27% 67.26% -0.01% ========================================== Files 571 571 Lines 104868 104877 +9 ========================================== - Hits 70547 70544 -3 - Misses 34321 34333 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #220546 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 1 month ago

✔️ 3863174437d115854ca3deea75c85d06adb1cc6e -> Azure artifacts URL