neuronsimulator / nrn

NEURON Simulator
http://nrn.readthedocs.io
Other
381 stars 114 forks source link

ParallelContext: hoc_ac_ encodes global id of submitted process. #2965

Closed nrnhines closed 1 month ago

nrnhines commented 1 month ago

This bug was introduced in

commit 728758db0663f945a6a7a7259ca5adea8bc1a1ae (HEAD)
Author: Michael Hines <michael.hines@yale.edu>
Date:   Thu Dec 21 07:28:01 2017 -0500

The documentation https://nrn.readthedocs.io/en/latest/python/modelspec/programmatic/network/parcon.html#ParallelContext.submit states

when the task is executed, the hocac variable is set to this unique id (positive integer) of the task

With this fix, the output of nrniv src/parallel/test6.hoc is now correct again. E.g. the third from last line is now

id=19 Test[1]: 361 = f(19, "goodbye", Vector[19])

instead of

id=0 Test[1]: 361 = f(19, "goodbye", Vector[19])

This fix should also be adopted in release/8.2

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 1 month ago

✔️ 4b809669850ce37da3a09ec7575534946a38db11 -> Azure artifacts URL

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.26%. Comparing base (17e107a) to head (4b80966).

Files Patch % Lines
src/parallel/ocbbs.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2965 +/- ## ========================================== - Coverage 67.26% 67.26% -0.01% ========================================== Files 571 571 Lines 104867 104879 +12 ========================================== + Hits 70543 70544 +1 - Misses 34324 34335 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #220829 (:white_check_mark:) have been uploaded here!

Status and direct links: