Force inlining for sparse_thread solver routine to fix performance regression

neuronsimulator / nrn

NEURON Simulator

http://nrn.readthedocs.io

Other

381 stars 114 forks source link

Force inlining for sparse_thread solver routine to fix performance regression #2966

Closed pramodk closed 1 month ago

pramodk commented 1 month ago

See discussion in #2787
Not all compilers (e.g. GCC) will inline sparse_thread.hpp routines, especially if generated functions contain many many calls.
From the testing of models in #2787, I don't see any issue if I force inlining with clang, gcc and Intel compiler.

fixes #2787

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #220858 (:white_check_mark:) have been uploaded here!

Status and direct links:

azure-pipelines[bot] commented 1 month ago

✔️ fcaf2cbb007a9a8b54262ac3fe0fcbca03fdc233 -> Azure artifacts URL

1uc commented 1 month ago

@pramodk btw, there was a formatting issue, the CI then pushed a fixup. Which then partially restarts the CI, but not everything, resulting in the state it's in now.

pramodk commented 1 month ago

Which then partially restarts the CI, but not everything, resulting in the state it's in now.

I "thought" that even though the bot pushes formatting, CI was starting correctly. But maybe my memory is faulty or something changed in the meantime.

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

azure-pipelines[bot] commented 1 month ago

✔️ 2213e16e84d5d219c4e186bf6c367b4300e12bd8 -> Azure artifacts URL

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.26%. Comparing base (17e107a) to head (2213e16).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2966 +/- ## ========================================== - Coverage 67.26% 67.26% -0.01% ========================================== Files 571 571 Lines 104867 104879 +12 ========================================== + Hits 70543 70545 +2 - Misses 34324 34334 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #220885 (:white_check_mark:) have been uploaded here!

Status and direct links: