Closed pramodk closed 1 month ago
✔️ f6dfb7b6da3a0a35633f4e79b98f5f5ddd47b319 -> Azure artifacts URL
Logfiles from GitLab pipeline #221707 (:white_check_mark:) have been uploaded here!
Status and direct links:
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.28%. Comparing base (
2ace814
) to head (367a9a8
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Logfiles from GitLab pipeline #221750 (:white_check_mark:) have been uploaded here!
Status and direct links:
✔️ 367a9a817be9d1968c7343ccea1d0eda379cd3ae -> Azure artifacts URL
@pramodk Is this the only place we need to add code like this? I would have expected to see other finalization code nearby, for example MPI_finalize
.
Our primary exit point is ivocmain_session()
and that's where we already have the finalization: https://github.com/neuronsimulator/nrn/blob/df21c819d45ea2a9f4aabe33893dd2a4c359b731/src/ivoc/ivocmain.cpp#L765
But I had the same question and was wondering if there is another exit point I am not aware. But I believe these two cover most if not all.
LIKWID_MARKER_CLOSE
before the application terminates.h.quit()
, this finalization call is missing, leading to errors such as: