kousu
commented
3 years ago Hi! I am just going back through my inbox and saw this now. I'll look over it.
Closed sandrinebedard closed 3 years ago
kousu
commented
3 years ago Hi! I am just going back through my inbox and saw this now. I'll look over it.
kousu
commented
3 years ago @sandrinebedard many files appear modified to me, instead of being additions. For example, derivatives/labels/sub-1141548/anat/sub-1141548_T1w_pmj-manual.nii.gz, with a corresponding change in its timestamp:
diff --git a/derivatives/labels/sub-1141548/anat/sub-1141548_T1w_pmj-manual.json b/derivatives/labels/sub-1141548/anat/sub-1141548_T1w_pmj-manual.json
index 4f07ef222..0f4f1596d 100644
--- a/derivatives/labels/sub-1141548/anat/sub-1141548_T1w_pmj-manual.json
+++ b/derivatives/labels/sub-1141548/anat/sub-1141548_T1w_pmj-manual.json
@@ -1,4 +1,4 @@
{
"Author": "Sandrine Bedard",
- "Date": "2021-07-19 17:28:17"
+ "Date": "2021-07-26 11:31:11"
}and in derivatives/labels/sub-1095748/anat/sub-1095748_T1w_labels-manual.nii.gz you appear to have replaced Etienne's work with your own:
diff --git a/derivatives/labels/sub-1095748/anat/sub-1095748_T1w_labels-manual.json b/derivatives/labels/sub-1095748/anat/sub-1095748_T1w_labels-manual.json
old mode 100755
new mode 100644
index 59b0dc513..63f88a412
--- a/derivatives/labels/sub-1095748/anat/sub-1095748_T1w_labels-manual.json
+++ b/derivatives/labels/sub-1095748/anat/sub-1095748_T1w_labels-manual.json
@@ -1,4 +1,4 @@
{
- "Author": "Etienne Bergeron",
- "Date": "2021-05-17 16:30:56"
+ "Author": "Sandrine Bedard",
+ "Date": "2021-07-27 14:41:24"
}
\ No newline at end of fileWas this on purpose or did these files get mis-named by accident?
By my count, these are the pure additions:
while these are the modifications:
If the modifications are on purpose, no biggie, let's just fix up the commit messages to match :)
kousu
commented
3 years ago @kousu I also wanted to add a release tag to the dataset after we merge this PR, not sure how to do that with git annex!
This is easy! Same as regular git: just git tag v1.0.0 && git push --tags origin
sandrinebedard
commented
3 years ago If the modifications are on purpose, no biggie, let's just fix up the commit messages to match :)
Yes the modified files are on purpose, when checking the results, I found some extra manual corrections to be done on some that were already done, that's why!
kousu
commented
3 years ago Alright it's merged. I squashed and rewrote your commit messages to be like this:
nguenther@data:~/datasets/uk-biobank-processed$ git log
commit 7ed28cd0aacaab0ce1570bccdba3bff495b5f496 (HEAD -> master, origin/master, origin/HEAD)
Author: Sandrine Bedard <sandrine.bedard@polymtl.ca>
Date: Sun Sep 5 17:49:04 2021 -0400
change suffix in derivatives from labels-manual to labels-disc-manual
commit 50ddb7cbf9c9a4a92f9da17506184648e3c19b57
Author: Sandrine Bedard <sandrine.bedard@polymtl.ca>
Date: Mon Jul 26 11:45:59 2021 -0400
add and improve segmentations, PMJ labels and verterbal disc labelsNext you want to make a tag? Let's do that here: https://github.com/neuropoly/data-management/issues/126
sandrinebedard
commented
3 years ago Alright it's merged. I squashed and rewrote your commit messages to be like this:
nguenther@data:~/datasets/uk-biobank-processed$ git log commit 7ed28cd0aacaab0ce1570bccdba3bff495b5f496 (HEAD -> master, origin/master, origin/HEAD) Author: Sandrine Bedard <sandrine.bedard@polymtl.ca> Date: Sun Sep 5 17:49:04 2021 -0400 change suffix in derivatives from labels-manual to labels-disc-manual commit 50ddb7cbf9c9a4a92f9da17506184648e3c19b57 Author: Sandrine Bedard <sandrine.bedard@polymtl.ca> Date: Mon Jul 26 11:45:59 2021 -0400 add and improve segmentations, PMJ labels and verterbal disc labelsNext you want to make a
tag? Let's do that here: #126
Great thanks! and yes I want to make a tag!
Description
This PR adds manual segmentations, PMJ labels and disc labeling to the derivatives of
uk-biobank-processed. It also renames disc derivatives from_labels-manualto_labels-disc-manual.The branch is
sb/add-extra-derivatives@kousu I also wanted to add a release tag to the dataset after we merge this PR, not sure how to do that with git annex!