neuropoly / data-management

Repo that deals with datalad aspects for internal use
4 stars 0 forks source link

update `derivatives` for`datasets/lumbar-epfl` #166

Open alexfoias opened 2 years ago

alexfoias commented 2 years ago

Added new segmentation on af/fix_seg for datasets/lumbar-epfl . Please note that only a few of them seemed to have changed.

 ~/d/lumbar-epfl ╱ af/fix_seg  git annex copy --to=origin                  ✔ ╱ base  ╱ 15:21:35
copy derivatives/labels/sub-01/anat/sub-01_T2w_seg-manual.nii.gz (to origin...)
ok
copy derivatives/labels/sub-02/anat/sub-02_T2w_seg-manual.nii.gz ok
copy derivatives/labels/sub-03/anat/sub-03_T2w_seg-manual.nii.gz (to origin...)
ok
copy derivatives/labels/sub-04/anat/sub-04_T2w_seg-manual.nii.gz (to origin...)
ok
copy derivatives/labels/sub-05/anat/sub-05_T2w_seg-manual.nii.gz (to origin...)
ok
copy derivatives/labels/sub-06/anat/sub-06_T2w_seg-manual.nii.gz (to origin...)
ok
copy derivatives/labels/sub-07/anat/sub-07_T2w_seg-manual.nii.gz ok
copy derivatives/labels/sub-08/anat/sub-08_T2w_seg-manual.nii.gz (to origin...)
ok
copy derivatives/labels/sub-09/anat/sub-09_T2w_seg-manual.nii.gz ok
copy derivatives/labels/sub-10/anat/sub-10_T2w_seg-manual.nii.gz ok
copy derivatives/labels/sub-11/anat/sub-11_T2w_seg-manual.nii.gz ok
copy sub-01/anat/sub-01_T2w.nii.gz ok
copy sub-02/anat/sub-02_T2w.nii.gz ok
copy sub-03/anat/sub-03_T2w.nii.gz ok
copy sub-04/anat/sub-04_T2w.nii.gz ok
copy sub-05/anat/sub-05_T2w.nii.gz ok
copy sub-06/anat/sub-06_T2w.nii.gz ok
copy sub-07/anat/sub-07_T2w.nii.gz ok
copy sub-08/anat/sub-08_T2w.nii.gz ok
copy sub-09/anat/sub-09_T2w.nii.gz ok
copy sub-10/anat/sub-10_T2w.nii.gz ok
copy sub-11/anat/sub-11_T2w.nii.gz ok
(recording state in git...)

@jcohenadad Could you please review the branch ?

jcohenadad commented 2 years ago

thank you @alexfoias, will do. Could you please also add the script you used to BIDSify the data

alexfoias commented 2 years ago

I pushed the script on the branch:

commit ec5ec02df23a4b1fced7f0186ceecc4caf1dc111 (HEAD -> af/fix_seg, origin/af/fix_seg)
Author: Alexandru Foias <afoias@polymtl.ca>
Date:   Thu Jan 13 16:36:22 2022 -0500

    add curation script

 scripts/curate_lumbar_epfl.py | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
alexfoias commented 2 years ago

@jcohenadad Whenever you have a few minutes, could you please review the branch in order to merge it ? Thank you.

kousu commented 2 years ago

This is absolutely a nitpick, but BIDS says to use code/, so before merging do something like:

git mv scripts code && git commit -m "Comply with BIDS"
jcohenadad commented 2 years ago

This is absolutely a nitpick, but BIDS says to use code/, so before merging do something like:

git mv scripts code && git commit -m "Comply with BIDS"

wow! good catch. I thought the BIDS recommendation was to use a folder 'scripts/'. Maybe they changed it? 🤷‍♂️ . Anyways, yes, i agree that's what we should do from now on