neuropoly / intranet.neuro.polymtl.ca

NeuroPoly's lab manual
https://intranet.neuro.polymtl.ca
4 stars 6 forks source link

Right menu does not display the current headings #58

Open jcohenadad opened 2 years ago

jcohenadad commented 2 years ago

When clicking on a headings in the right TOC, the page goes at the correct headings, but the right TOC does not. See:

https://user-images.githubusercontent.com/2482071/175317384-c4494f62-af15-4b9e-b597-71bac40d728d.mov

kousu commented 2 years ago

Looks like it's just pages with subheadings. It looks like the right ToC is being synced via javascript based on the current y value on the page, not based on what's clicked (which makes sense), but its estimate is a bit off, and it's falling upwards, selecting the previous heading on for example all of these:

This would probably be avoided if we reconsidered #22, which has much simpler code and is designed to be easier to get right. For example, this sub-subheading (on a site using furo) jumps correctly: