neuropoly / neuro.polymtl.ca

NeuroPoly's Website
https://neuro.polymtl.ca
3 stars 5 forks source link

Weird emojis after upgrade #89

Closed jcohenadad closed 1 year ago

jcohenadad commented 1 year ago

A recent modification (I suspect it is d0d5064ff22172774993549b176e12a2c845ec32, @mguaypaq can confirm) changed the appearance of the page, including the emojis, which now appear within a box:

image

Note that the intranet has a mix of those:

image

The ones with the box are written as:

`❤️`

Whereas the ones without the box are written as:

<span>❤️</span>

Few questions:

mguaypaq commented 1 year ago

I see the same thing (all boxes for the external website, some boxes for the intranet, firefox on debian). I'll try out the variations you suggest and make sure there are no boxes anywhere.

mguaypaq commented 1 year ago

Ah, now I see the reason for including "\": it's to trigger the following CSS rule: https://github.com/neuropoly/intranet.neuro.polymtl.ca/blob/2fc91df449025396d813c90aef9a01aab6fce2bf/_static/theme.css#L39-L46 This makes the leading emojis in the table of contents on the left side have all the same size, so that the page titles are all aligned. So the real solution is to standardize on "\". I'll do that now.

mguaypaq commented 1 year ago

Fixed in https://github.com/neuropoly/neuro.polymtl.ca/commit/0075a3ee1f00e16c8e77a66535fd6c7f14b0c0c7.