neuropoly / slicer-manual-annotation

MIT License
1 stars 1 forks source link

Crash when selecting volume folder #49

Open jcohenadad opened 1 month ago

jcohenadad commented 1 month ago

Describe the bug

When clicking "Select volume folder" and then canceling, I get the spinning cursor and Slicer does not respond anymore. See video recording:

https://github.com/user-attachments/assets/e8bae465-6762-4d8a-ac13-898f5185b53b

Crash report (only the first chunk) ```console Date/Time: 2024-07-17 09:52:49.085 -0400 End time: 2024-07-17 09:53:09.572 -0400 OS Version: macOS 14.0 (Build 23A344) Architecture: x86_64h Report Version: 44 Incident Identifier: 3AFD3824-25DA-4328-A176-6810CFDE1F7C Data Source: Stackshots Shared Cache: 62BFF6A2-85E3-3E99-AA9C-94B8C34708C1 slid base address 0x7ff81b223000, slide 0x1b223000 (System Primary) Shared Cache: 5B402DF7-4F21-34EF-A11C-84A9B750A01D slid base address 0x7ff8016be000, slide 0x16be000 (DriverKit) Command: Slicer Path: /Applications/Slicer.app/Contents/MacOS/Slicer Identifier: org.slicer.slicer Version: 5.6.2 (5.6.2) Team ID: W38PE5Y733 Is First Party: No Architecture: x86_64 Parent: launchd [1] PID: 6503 Time Since Fork: 105s Event: hang Duration: 20.49s Duration Sampled: 1.60s (process was unresponsive for 19 seconds before sampling) Steps: 16 (100ms sampling interval) Hardware model: MacBookPro16,1 Active cpus: 12 HW page size: 4096 VM page size: 4096 Time Since Boot: 4676s Time Awake Since Boot: 4676s Time Since Wake: n/a (machine hasn't slept) Fan speed: 3194 rpm Total CPU Time: 3.000s (10.4G cycles, 12.0G instructions, 0.87c/i) Advisory levels: Battery -> 3, User -> 2, ThermalPressure -> 0, Combined -> 2 Free disk space: 8603.69 MB/465.63 GB, low space threshold 3072 MB Vnodes Available: 72.31% (190303/263168) Preferred User Language: en-CA Country Code: CA OS Cryptex File Extents: 64 ```
AcastaPaloma commented 1 month ago

I added if not self.CurrentFolder: return

beneath def onSelectVolumesFolderButton(self): self.CurrentFolder= qt.QFileDialog.getExistingDirectory(None,"Open a folder", self.DefaultDir, qt.QFileDialog.ShowDirsOnly) to see if it would solve the issue. Seems it did? It doesn't tackle the root cause though.