Instead of this which imposes an Hamilton segmenter, I would suggest to implement the part present in ecg_preprocess doing the same job in the ecg_find_peaks method and call it from the ecg_preprocess method. This would enable the use of other segmenters in ecg_find_peaks (and be, in my opinion, cleaner implementation 😄 ).
Instead of this which imposes an Hamilton segmenter, I would suggest to implement the part present in
ecg_preprocess
doing the same job in theecg_find_peaks
method and call it from theecg_preprocess
method. This would enable the use of other segmenters inecg_find_peaks
(and be, in my opinion, cleaner implementation 😄 ).If you agree on that, I can implement it.