neuropsychology / NeuroKit.py

A Python Toolbox for Statistics and Neurophysiological Signal Processing (EEG, EDA, ECG, EMG...).
http://neurokit.rtfd.io
MIT License
363 stars 102 forks source link

ecg_find_peaks method imposes the use of an hamilton segmenter. #43

Open lamourj opened 6 years ago

lamourj commented 6 years ago

Instead of this which imposes an Hamilton segmenter, I would suggest to implement the part present in ecg_preprocess doing the same job in the ecg_find_peaks method and call it from the ecg_preprocess method. This would enable the use of other segmenters in ecg_find_peaks (and be, in my opinion, cleaner implementation 😄 ).

If you agree on that, I can implement it.

DominiqueMakowski commented 6 years ago

Yep, sounds like a great idea 😄 Please do your magic ;)